Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: Run cosa kola --basic-qemu-scenarios #187

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

cgwalters
Copy link
Member

So we test NVMe root disk, Secure Boot etc.
See coreos/coreos-assembler#1029

So we test NVMe root disk, Secure Boot etc.
See coreos/coreos-assembler#1029
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I especially appreciate the link to working logs.

@@ -33,6 +33,21 @@ node {
}
}

// Parse and handle the result of Kola
boolean checkKolaSuccess(currentBuild) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is the kind of thing that we can push up into coreos-ci-lib at some point.

@jlebon jlebon merged commit 90956f3 into coreos:master Jan 15, 2020
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Feb 6, 2020
Same rationale as coreos/fedora-coreos-pipeline#187
Motivated by ensuring we're covering proposed changes like
coreos#1105
in CI here too.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Feb 6, 2020
Same rationale as coreos/fedora-coreos-pipeline#187
Motivated by ensuring we're covering proposed changes like
coreos#1105
in CI here too.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Feb 6, 2020
Same rationale as coreos/fedora-coreos-pipeline#187
Motivated by ensuring we're covering proposed changes like
coreos#1105
in CI here too.
openshift-merge-robot pushed a commit to coreos/coreos-assembler that referenced this pull request Feb 6, 2020
Same rationale as coreos/fedora-coreos-pipeline#187
Motivated by ensuring we're covering proposed changes like
#1105
in CI here too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants