Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run --basic-qemu-scenarios #1106

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

cgwalters
Copy link
Member

Same rationale as coreos/fedora-coreos-pipeline#187
Motivated by ensuring we're covering proposed changes like
#1105
in CI here too.

@jlebon
Copy link
Member

jlebon commented Feb 6, 2020

/lgtm

Same rationale as coreos/fedora-coreos-pipeline#187
Motivated by ensuring we're covering proposed changes like
coreos#1105
in CI here too.
@cgwalters
Copy link
Member Author

OK now that I found the clicky interface to retry in Jenkins I'll stop re-pushing to retrigger, let's do another /lgtm here?

@jlebon
Copy link
Member

jlebon commented Feb 6, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7afc6a3 into coreos:master Feb 6, 2020
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
Match what `ore aws upload` does and delete the OSS file by default
after the image was successfully uploaded. Then the GC strategy for
pipelines is just about cleaning up old images, and we don't have to
worry about the bucket too.

Closes: coreos#1106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants