Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic test for podman-quadlet #2216

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Add basic test for podman-quadlet #2216

merged 2 commits into from
Feb 10, 2023

Conversation

travier
Copy link
Member

@travier travier commented Feb 3, 2023

@travier travier mentioned this pull request Feb 3, 2023
Closed
@travier
Copy link
Member Author

travier commented Feb 3, 2023 •
edited
Loading

Trying this, I get:

warning: Couldn't find locked package 'podman-5:4.4.0-1.fc37'
  Packages matching NEVRA: 0; Mismatched checksums: 0
  Packages matching name and arch (18):
  podman-3:4.0.1-2.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.0.1-2.fc37.x86_64 (fedora-coreos-pool)
  podman-3:4.0.2-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.0.3-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.0-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.0-8.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.1-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.1-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.1.1-3.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.2.0-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.2.0-2.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.2.1-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.2.1-2.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.3.0-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.3.0-2.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.3.1-1.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.2.1-2.fc37.x86_64 (fedora)
  podman-4:4.3.1-1.fc37.x86_64 (fedora-updates)
warning: Couldn't find locked package 'podman-quadlet-5:4.4.0-1.fc37'
  Packages matching NEVRA: 0; Mismatched checksums: 0
  No packages matched name: podman-quadlet arch: 
error: Packages not found: podman, podman-quadlet

Looks like it's not looking at the testing repo.

@dustymabe
Copy link
Member

CI is failing with:

No such rpm: containers-common-1-78.fc37.x86_64

Maybe you need to fast-track other packages?

@dustymabe
Copy link
Member

dustymabe commented Feb 3, 2023 •
edited
Loading

Trying this, I get:

warning: Couldn't find locked package 'podman-5:4.4.0-1.fc37'
  Packages matching NEVRA: 0; Mismatched checksums: 0
  Packages matching name and arch (18):
  podman-3:4.0.1-2.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.0.1-2.fc37.x86_64 (fedora-coreos-pool)
  podman-3:4.0.2-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.0.3-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.0-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.0-8.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.1-1.fc36.x86_64 (fedora-coreos-pool)
  podman-3:4.1.1-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.1.1-3.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.2.0-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.2.0-2.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.2.1-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.2.1-2.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.3.0-2.fc36.x86_64 (fedora-coreos-pool)
  podman-4:4.3.0-2.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.3.1-1.fc37.x86_64 (fedora-coreos-pool)
  podman-4:4.2.1-2.fc37.x86_64 (fedora)
  podman-4:4.3.1-1.fc37.x86_64 (fedora-updates)
warning: Couldn't find locked package 'podman-quadlet-5:4.4.0-1.fc37'
  Packages matching NEVRA: 0; Mismatched checksums: 0
  No packages matched name: podman-quadlet arch: 
error: Packages not found: podman, podman-quadlet

Looks like it's not looking at the testing repo.

you need to stick the RPMs in overrides/rpm if you are testing this locally. Then cosa fetch --with-cosa-overrides && cosa build.

@travier
Copy link
Member Author

travier commented Feb 3, 2023

Thanks, was missing the --with-cosa-overrides flag.

CI is failing with:

No such rpm: containers-common-1-78.fc37.x86_64

Maybe you need to fast-track other packages?

According to https://bodhi.fedoraproject.org/updates/FEDORA-2023-20624cd618, it should even be in stable now.

dustymabe
dustymabe reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this Timothee!

tests/kola/containers/quadlet/config.bu Outdated Show resolved Hide resolved
tests/kola/containers/quadlet/test.sh Outdated Show resolved Hide resolved
tests/kola/containers/quadlet/test.sh
#!/bin/bash
## kola:
## # We're pulling a container image from Quay.io
## tags: "platform-independent needs-internet"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do have other tests that pull containers that are exclusive: false. This one is probably on the fence of "making meaningful changes to the system" or not so I could go either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. We'll setup networks for containers and volumes. This should not interact with other things but the more container related tests we merge the more likely we'll have issues.

@dustymabe
Copy link
Member

CI is failing with:

No such rpm: containers-common-1-78.fc37.x86_64

Maybe you need to fast-track other packages?

According to https://bodhi.fedoraproject.org/updates/FEDORA-2023-20624cd618, it should even be in stable now.

Then remove it from the manifest-lock.overrides.yaml file.

@travier
Copy link
Member Author

travier commented Feb 3, 2023

I'm starting with the examples from https://github.com/containers/podman/blob/main/docs/source/markdown/podman-systemd.unit.5.md#examples, which apparently don't fully work.

@jlebon

This comment was marked as outdated.

Sign in to view
@travier travier force-pushed the quadlet branch 2 times, most recently from 2f4812c to 23de5cb Compare February 3, 2023 16:01
@travier
Copy link
Member Author

travier commented Feb 3, 2023

containers/podman#17354

@travier travier mentioned this pull request Feb 3, 2023
Merged
@travier
Copy link
Member Author

travier commented Feb 3, 2023

OK, next step would be to test pods.

LorbusChris
LorbusChris suggested changes Feb 6, 2023
View reviewed changes
manifests/fedora-coreos-base.yaml Outdated Show resolved Hide resolved
@travier
Copy link
Member Author

travier commented Feb 10, 2023 

[2023-02-10T16:37:58.026Z] --- PASS: ext.config.containers.quadlet (26.24s)

@dustymabe
Copy link
Member

The upgrade test in CI failed because of a signature issue that I'm aware of and will fix. For now we can ignore the failure.

dustymabe
dustymabe approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier travier marked this pull request as ready for review February 10, 2023 17:12
@travier travier changed the title manifests/user-experience: Add podman-quadlet Add basic test for podman-quadlet Feb 10, 2023
@dustymabe dustymabe merged commit 41061b1 into coreos:testing-devel Feb 10, 2023
@travier travier deleted the quadlet branch February 10, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorbusChris LorbusChris LorbusChris requested changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include new podman with quadlet functionality
4 participants
@travier @dustymabe @jlebon @LorbusChris