Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] docs/podman-systemd.unit: Update example to work out of the box + Explicitely mention '.network' units #17354

Merged
merged 2 commits into from
Feb 7, 2023
Merged

[CI:DOCS] docs/podman-systemd.unit: Update example to work out of the box + Explicitely mention '.network' units #17354

merged 2 commits into from
Feb 7, 2023
+9 −5

Conversation

travier
Copy link
Member

@travier travier commented Feb 3, 2023

docs/podman-systemd.unit: Update example to work out of the box

  • Don't order the container unit before local-fs.target as that creates
    an ordering cycle that triggers other issues.
  • Use the example network in the container unit
  • Only use groups that exists by default for the volume

Signed-off-by: Timothée Ravier [email protected]

docs/podman-systemd.unit: Explicitely mention '.network' units

Make the relation between '.container' and '.network' units more
explicit at the beginning.

Signed-off-by: Timothée Ravier [email protected]

Does this PR introduce a user-facing change?

No, docs only.

None

@travier travier mentioned this pull request Feb 3, 2023
Merged
@travier
Copy link
Member Author

travier commented Feb 3, 2023

From working on tests for Fedora CoreOS: coreos/fedora-coreos-config#2216

@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2023

Please hold off on merging this until my PR goes in.

@travier
Copy link
Member Author

travier commented Feb 5, 2023

Link to likely PR to wait for: #17351

@travier
Copy link
Member Author

travier commented Feb 6, 2023

Rebased now that #17351 has been merged.

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

I think we should add some kind of table to this man page, to make it easier to view. But that would be for another PR.

@rhatdan rhatdan closed this Feb 6, 2023
@rhatdan rhatdan reopened this Feb 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

@travier You need to rebase your PR, since the CI/CD system is broken. Rebasing will get you the fix.

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

LGTM
@containers/podman-maintainers PTAL
Thansk @travier

@travier
docs/podman-systemd.unit: Update example to work out of the box
c4f338e 
- Don't order the container unit before local-fs.target as that creates
  an ordering cycle that triggers other issues.
- Use the example network in the container unit
- Only use groups that exists by default for the volume

Signed-off-by: Timothée Ravier <[email protected]>
@travier
docs/podman-systemd.unit: Explicitely mention network & kube units
4e8906c 
Make the relation between '.container' and '.network' units more
explicit at the beginning.

Signed-off-by: Timothée Ravier <[email protected]>
@travier
Copy link
Member Author

travier commented Feb 6, 2023

Rebased

vrothberg
vrothberg approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you, @travier !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travier, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit c4ec99a into containers:main Feb 7, 2023
@travier travier deleted the quadlet-examples branch February 7, 2023 15:31
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dustymabe dustymabe dustymabe left review comments

@rhatdan rhatdan rhatdan left review comments

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@travier @rhatdan @dustymabe @vrothberg @openshift-merge-robot