Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: check for FAT32 ESP #1273

Closed
wants to merge 1 commit into from
Closed

tests: check for FAT32 ESP #1273

wants to merge 1 commit into from

Conversation

bgilbert
Copy link
Contributor

@dustymabe
Copy link
Member

The current goal is to move away from misc-ro towards smaller and more scoped tests (see #1228). The primary benefit of misc-ro (running tests in a single VM) is now handled additionally by marking a test as exclusive: false. Would you mind breaking it out to a separately defined test with exclusive: false? Otherwise we'll do it as part of #1228.

@bgilbert bgilbert changed the title kola/tests/misc-ro: check for FAT32 ESP tests: check for FAT32 ESP Oct 12, 2021
@bgilbert
Copy link
Contributor Author

Done!

@bgilbert
Copy link
Contributor Author

Updated.

jlebon
jlebon previously approved these changes Oct 12, 2021
View reviewed changes
dustymabe
dustymabe previously approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one suggestion

@bgilbert bgilbert dismissed stale reviews from dustymabe and jlebon via a5e61dd October 12, 2021 18:23
@bgilbert bgilbert requested a review from dustymabe October 12, 2021 18:24
@dustymabe
Copy link
Member

👍

@dustymabe
Copy link
Member

and it's working! CI tests failed with:

fatal 'EFI System Partition is not FAT32'

because coreos/coreos-assembler#2491 hasn't landed yet.

@bgilbert
Copy link
Contributor Author

Closing per consensus in coreos/fedora-coreos-tracker#993 (comment).

@bgilbert bgilbert closed this Oct 14, 2021
@bgilbert bgilbert deleted the fat32/testing-devel branch October 14, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@jlebon jlebon jlebon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgilbert @dustymabe @jlebon