Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_disk: switch ESP from FAT16 to FAT32 #2491

Closed
wants to merge 1 commit into from
Closed

create_disk: switch ESP from FAT16 to FAT32 #2491

wants to merge 1 commit into from

Conversation

bgilbert
Copy link
Contributor

The UEFI spec requires FAT32.

Fixes coreos/fedora-coreos-tracker#993.

This was referenced Oct 12, 2021
Closed
Open
dustymabe
dustymabe approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert enabled auto-merge (rebase) October 12, 2021 17:43
@dustymabe
Copy link
Member

Weird test error:

[2021-10-12T18:58:31.481Z] + kola testiso -S --qemu-native-4k --no-pxe --output-dir tmp/kola-testiso-metal4k
[2021-10-12T18:58:31.481Z] Testing scenarios: [iso-offline-install iso-live-login iso-as-disk]
[2021-10-12T18:58:31.481Z] Ignoring verification of signature on metal image
[2021-10-12T19:01:22.906Z] Error: scenario iso-offline-install: Unexpected string from completion channel: live-test-OK expected: coreos-installer-test-OK
[2021-10-12T19:01:22.906Z] 2021-10-12T19:01:21Z cli: scenario iso-offline-install: Unexpected string from completion channel: live-test-OK expected: coreos-installer-test-OK
script returned exit code 1

@bgilbert bgilbert disabled auto-merge October 12, 2021 21:42
@bgilbert bgilbert marked this pull request as draft October 12, 2021 23:29
@bgilbert
Copy link
Contributor Author

That error is because the firmware is ignoring the installed OS and booting back into the ISO: coreos/fedora-coreos-tracker#993 (comment)

@dustymabe
Copy link
Member

That error is because the firmware is ignoring the installed OS and booting back into the ISO: coreos/fedora-coreos-tracker#993 (comment)

This is a moment to step back and thank everyone who has worked really really hard to invest in our CI and to try to cover as many cases as possible. This wouldn't have been caught without it.

@bgilbert
Copy link
Contributor Author

This is a moment to step back and thank everyone who has worked really really hard to invest in our CI and to try to cover as many cases as possible. This wouldn't have been caught without it.

Yes, absolutely. In a couple years we've come from no CI at all, to a substantial collection of systems cross-checking nearly all of our daily work. Thank you all for your work building this and keeping it running! 🙇‍♂️

@bgilbert
Copy link
Contributor Author

Closing per consensus in coreos/fedora-coreos-tracker#993 (comment).

@bgilbert bgilbert closed this Oct 14, 2021
@bgilbert bgilbert deleted the fat32 branch October 14, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqibali-2k saqibali-2k saqibali-2k approved these changes

@jlebon jlebon jlebon approved these changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change EFI-System partition format from fat16 to fat32
4 participants
@bgilbert @dustymabe @jlebon @saqibali-2k