-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/cmdlib.sh: Work-around for OpenShift 3.9 not including .git [#320] #324
Conversation
src/cmdlib.sh
Outdated
|
||
# Openshift 3.9 does not expose the GIT Repo. | ||
# See https://github.com/coreos/coreos-assembler/issues/320 | ||
# TODO: Remove this when https://github.com/openshift/source-to-image/issues/457 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that issue is closed so maybe we need more guidance on when we can remove this (i.e. when based on Openshift XX with S2I YY)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change logs are not really helpful on either Openshift or S2I. Still hunting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like version v1.0.6 of the Source-to-Image has the change However, I can't find which version of Openshift has that in the default ose-docker-builder
container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess we could pull the container and find out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One would think so:
ben@porpentina:~ $ sudo podman run --rm -it openshift3/ose-docker-builder:v3.10.45-5 version
openshift-docker-build v3.10.45
That's not the case.
For git commands that treat failures as "unknown", this hides the error message itself.
LGTM! |
This address #320 by allowing for Opendshift s2i builds to work in 3.9. Example: