container build failing in OpenShift 3.9

[miabbott]

On our internal OpenShift 3.9 instance, there is a BuildConfig defined for building the coreos-assembler container. It built successfully from 4bbdbba a few days ago, but when I try to build it again today, it is failing.

The BuildConfig looks like this:

$ /usr/local/bin/oc get bc/coreos-assembler -o yaml                                                                                                                                              
apiVersion: build.openshift.io/v1
kind: BuildConfig
spec:
  failedBuildsHistoryLimit: 5
  nodeSelector: {}
  output:
    to:
      kind: ImageStreamTag
      name: coreos-assembler:latest
  postCommit: {}
  resources:
    limits:
      memory: 4000Mi
  runPolicy: Serial
  source:
    git:
      ref: master
      uri: https://github.com/coreos/coreos-assembler
    type: Git
  strategy:
    dockerStrategy:
      from:
        kind: ImageStreamTag
        name: fedora:29
        namespace: redhat-coreos
    type: Docker
  successfulBuildsHistoryLimit: 5
  triggers: []
status:
  lastVersion: 2

The failing part of the build:

Removing intermediate container f5240a0e9da3
Step 7/16 : RUN ./build.sh write_archive_info
 ---> Running in 48555f5281ac
++ pwd
+ srcdir=/root/containerbuild
+ write_archive_info
+ . /root/containerbuild/src/cmdlib.sh
++ set -euo pipefail
+++ dirname ./build.sh
++ DIR=.
++ RFC3339=%Y-%m-%dT%H:%M:%SZ
++ export PYTHONUNBUFFERED=1
++ PYTHONUNBUFFERED=1
++ grep -q '^Fedora' /etc/redhat-release
++ export ISFEDORA=1
++ ISFEDORA=1
++ export ISEL=
++ ISEL=
++ _privileged=
+ mkdir -p /cosa /lib/coreos-assembler
+ touch -f /lib/coreos-assembler/.clean
+ prepare_git_artifacts /root/containerbuild /cosa/coreos-assembler-git.tar.gz /cosa/coreos-assembler-git.json
+ local gitd=/root/containerbuild
+ shift
+ local tarball=/cosa/coreos-assembler-git.tar.gz
+ shift
+ local json=/cosa/coreos-assembler-git.json
+ shift
+ local is_dirty=false
+ local head_ref=unknown
+ local head_remote=unknown
+ local head_url=unknown
+ local 'gc=git --work-tree=/root/containerbuild --git-dir=/root/containerbuild/.git'
+ git --work-tree=/root/containerbuild --git-dir=/root/containerbuild/.git diff --quiet --exit-code
Not a git repository
To compare two paths outside a working tree:
usage: git diff [--no-index] <path> <path>
+ is_dirty=true
+ tar -C /root/containerbuild -czf /cosa/coreos-assembler-git.tar.gz --exclude-vcs .
+ chmod 0444 /cosa/coreos-assembler-git.tar.gz
+ local rev
+ local branch
++ git --work-tree=/root/containerbuild --git-dir=/root/containerbuild/.git rev-parse HEAD
fatal: not a git repository: '/root/containerbuild/.git'
+ rev=
Removing intermediate container 48555f5281ac
error: build error: The command '/bin/sh -c ./build.sh write_archive_info' returned a non-zero code: 128
error: the build redhat-coreos/micah-coreos-assembler-2 status is "Failed"

@darkmuggle this looks like it is part of the changes you did for prepare_git_artifacts

[miabbott]

I thought about this some more after submitting it and I wonder if there is something happening in OpenShift that requires us to tweak the BuildConfig.

[cgwalters]

I think an issue is actually that OpenShift builds by default don't give you the git repository inside the build. (But you do get those labels outside) There's an issue for this somewhere...

[darkmuggle]

@cgwalters you are correct, and you commented on the issue actually:
openshift/source-to-image#457

Looking at a work around.

[miabbott]

Laughing at the fact that we solved this previously in #28 😆

[darkmuggle]

PR submitted. Pending acceptance. Testing in Quay showed it works as expected.

[darkmuggle]

Closing this out, PR was merged.