Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: fix request body #23

Merged
merged 1 commit into from
Sep 18, 2019
Merged

examples: fix request body #23

merged 1 commit into from
Sep 18, 2019

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Sep 13, 2019

This updates example body according to latest decisions.

Ref: #12
Ref: #1

This updates example body according to latest decisions.
@lucab lucab requested a review from arithx as a code owner September 13, 2019 14:43
@lucab
Copy link
Contributor Author

lucab commented Sep 18, 2019

@arithx this one is very trivial but it needs a stamp too.

Copy link

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM

@@ -1,6 +1,6 @@
{
"client_params": {
"group": "workers",
"node_uuid": "c988d250-9fdf-4cdc-bed3-9037c56406fb"
"group": "default",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason changing this? It is still workers in #1

Copy link
Contributor Author

@lucab lucab Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it easy to test/debug a bare configuration with just the default group.
But good catch, I've updated the example in #1 so that they are in sync.

@lucab lucab merged commit 2443229 into coreos:master Sep 18, 2019
@lucab lucab deleted the ups/example-body branch September 18, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants