Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol: define UUID textual format #12

Open
lucab opened this issue May 15, 2019 · 2 comments
Open

protocol: define UUID textual format #12

lucab opened this issue May 15, 2019 · 2 comments

Comments

@lucab
Copy link
Contributor

lucab commented May 15, 2019

Airlock uses node UUID to identify HTTP clients and lock holders. However, when serialized to textual form, UUID may have several representations. In particular, there are two that are relevant here:

  • canonical form: 28c20a4a-64dd-488d-925c-1d591637ca8e
  • systemd form: 28c20a4a64dd488d925c1d591637ca8e

Dashes are just visual sugar for humans. Systemd uses the non-dashed form everywhere by default.
We should pick one of the two forms, document it, and use it everywhere in an uniform way.

@lucab
Copy link
Contributor Author

lucab commented Aug 21, 2019

I'm going for the systemd form here, as the main producer in our case is Zincati which uses the non-dashed form.

@lucab
Copy link
Contributor Author

lucab commented Sep 23, 2019

@arithx I'm thinking of relaxing this a bit more and just take a generic id string with a reasonable upper length-limit.

I think that would make the protocol easier to use in environments where nodes may already be part of an orchestrated cluster and identified by some other labeling scheme (e.g. k8s manages machines by node-name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant