-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add firefox support #3666
Closed
Closed
add firefox support #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * wip * adds gitignore * cleanup * cleanup * cleanup * fixes * wip * cleanup * fix * removes tsbuildinfo * ignore tsbuildinfo * cleanup * try out box * consolidate theme * View->Box * get it working frrr * fix theme * removes react-native-core * adds comment around tamaguiloaderconfiguration * moves alias over to this webpack config * removes circle * move theme up top to share between everything * adds it back into webpack.dev.config.js * updates
* fix: show info on deleted message * fix: use icon color * fix: imports
* Fixes * stuff * FIxed ui * Fixed poke * Fixed poke
* fix deriving on bad paths * add more tests * allow recovery of bad paths * move blockchain into wallet descriptor type * revert changes to onboarding provider:w * remove blockchain param from use signed wallet * stash
* wip * force close parent and spacing tweak
* Added spotlight * fixed soptlight
…3546) * Make Sure that the two users in a DM Chat don't have the same color * Reformat packages/tamagui-core/src/hooks/chat/useChatsWithMetadata.tsx Co-authored-by: Getabalew Tesfaye <[email protected]> * Reformat packages/tamagui-core/src/hooks/chat/useChatsWithMetadata.tsx Co-authored-by: Getabalew Tesfaye <[email protected]> * Add Map of UserId to ColorIndex to not update the users Variable #3459 * Use Map.set() and Map.get() --------- Co-authored-by: Getabalew Tesfaye <[email protected]>
(#3625) Co-authored-by: venkateshzoft <[email protected]>
* consolidate nft sending * consolidate sending transactions
* init * fix nft sending * fix balances * fix useravatar * updates * combines send helpers * parse TextEncoder / TextDecoer * fix nft sending * tbd
updates feature-gates, jupiter-proxy and version workers
if there are no Jupiter routes for the token, or if there is a zero balance of the token, then hide the swap button on the token info page
This reverts commit 9cdb560.
* expo patch * fix * merge other stuff
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
armaniferrante
force-pushed
the
master
branch
from
December 25, 2023 09:55
f4232de
to
33f7b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1496
This adds an
extension id
to the manifest and changes thebackground script
reference to an mv2 style script as firefox doesn't yet (and might never) support service worker background scripts as, like Safari, it is opting for Event Pages instead.It could require a lot of both upfront work and continuous maintenance to run both an mv3 background service worker and mv2 style background script in the same codebase.
I'm leaning towards punting this issue until there is more clarity on whether or not Mozilla will add support for background service workers.
If we decided to push ahead anyway it is probably worth looking into using something like comlink where we could have an agnostic proxy that would sit between the frontend and backend scripts. It would also give us strong types across the boundary which could be of huge benefit.
Further info