remove unused css classes #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| Name | Status | Previous | Current |
|---|---|---|---|
eslint-plugin-mui-unused-classes |
1.0.3 | 2.0.0 |
wentokay
force-pushed
the
wen/eslint-css
branch
from
cfd9496 to
2f60af5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unused css classes weren't being picked up by
eslint-plugin-mui-unused-classesanymore because the function name had changed frommakeStylestostyleson reflection it might've been easier to either change the eslint rule to pick up blocks called
stylesor renamedstylestomakeStylesbut then there's a chance people might import the wrong function. For now I changedimport { styles }toimport { styles as makeStyles }I had to add some other changes because of eslint errors, when it involved requiring changes that might affect the functionality of backpack without testing them I put eslint ignores for now, but they should be addressed at some point