Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bump go version in credential helper example #1749

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

aioue
Copy link
Contributor

@aioue aioue commented Sep 4, 2023

Amazon credential helper updates mean using GO 1.16 will cause slice errors. e.g.

undefined: unsafe.Slice

Using 1.17 as the source FROM fixes this.

Amazon credential helper updates mean using GO 1.16 will cause slice errors. e.g.

```
undefined: unsafe.Slice
```

Using 1.17 as the source FROM fixes this.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

@piksel piksel changed the title Update private-registries.md Bump go version in credential helper example Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2e643ed) 67.60% compared to head (1f35283) 67.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1749   +/-   ##
=======================================
  Coverage   67.60%   67.60%           
=======================================
  Files          26       26           
  Lines        2380     2380           
=======================================
  Hits         1609     1609           
  Misses        672      672           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing your solution!

@piksel piksel merged commit b801b63 into containrrr:main Sep 5, 2023
@piksel piksel changed the title Bump go version in credential helper example docs: bump go version in credential helper example Sep 5, 2023
@aioue aioue deleted the patch-1 branch November 15, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants