Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: "change golang base image" #1744

Closed
wants to merge 2 commits into from

Conversation

cloudsbird
Copy link

it's no longer working with 1.16, but it's working with 1.18.

Solving issues #1719

it's no longer working with 1.16, but it's working with 1.18.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (36391b0) 67.60% compared to head (2701ff0) 67.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1744   +/-   ##
=======================================
  Coverage   67.60%   67.60%           
=======================================
  Files          26       26           
  Lines        2380     2380           
=======================================
  Hits         1609     1609           
  Misses        672      672           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel
Copy link
Member

piksel commented Sep 10, 2023

This was fixed in #1749 (a later PR, sorry for not catching your contribution).

@piksel piksel closed this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants