Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/utils: Rename parameter in ParseRelease #835

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

HarryMichal
Copy link
Member

It was not apparent on first glance that the second parameter
represented a release (resp. tag).

@HarryMichal HarryMichal added 6. Minor Change Should not cause breakage 3. Refinement Reduces technical debt of the codebase 2. Under The Hood Multiple areas of the app are influenced by this ticket labels Jul 8, 2021
HarryMichal added a commit to HarryMichal/toolbox that referenced this pull request Jul 8, 2021
It was not apparent on first glance that the second parameter
represented a release (resp. tag).

containers#835
@HarryMichal HarryMichal force-pushed the pkg/utils/rename-parameter branch from c0ae780 to ff21f61 Compare July 8, 2021 13:45
@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal HarryMichal added this to the Release 0.1.0 milestone Jul 8, 2021
HarryMichal added a commit to HarryMichal/toolbox that referenced this pull request Jul 15, 2021
@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal HarryMichal force-pushed the pkg/utils/rename-parameter branch from c693a66 to ff21f61 Compare July 16, 2021 15:10
HarryMichal added a commit to HarryMichal/toolbox that referenced this pull request Jul 16, 2021
@softwarefactory-project-zuul
Copy link

Build succeeded.

It was not apparent on first glance that the second parameter
represented a release (resp. tag).

containers#835
@HarryMichal HarryMichal force-pushed the pkg/utils/rename-parameter branch from ff21f61 to a51bd73 Compare July 16, 2021 15:33
@softwarefactory-project-zuul
Copy link

Build succeeded.

@HarryMichal HarryMichal merged commit f761791 into containers:main Jul 16, 2021
@HarryMichal HarryMichal deleted the pkg/utils/rename-parameter branch July 16, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. Under The Hood Multiple areas of the app are influenced by this ticket 3. Refinement Reduces technical debt of the codebase 6. Minor Change Should not cause breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant