pkg/utils: Test ParseRelease

#835

src/pkg/utils/utils_test.go

@@ -17,6 +17,7 @@
 package utils
 
 import (
+	"strconv"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -72,3 +73,101 @@ func TestImageReferenceCanBeID(t *testing.T) {
 		})
 	}
 }
+
+func TestParseRelease(t *testing.T) {
+	testCases := []struct {
+		name         string
+		inputDistro  string
+		inputRelease string
+		output       string
+		ok           bool
+		err          error
+		errMsg       string
+	}{
+		{
+			name:         "Fedora; f34; valid",
+			inputDistro:  "fedora",
+			inputRelease: "f34",
+			output:       "34",
+			ok:           true,
+		},
+		{
+			name:         "Fedora; 33; valid",
+			inputDistro:  "fedora",
+			inputRelease: "33",
+			output:       "33",
+			ok:           true,
+		},
+		{
+			name:         "Fedora; -3; invalid; less than 0",
+			inputDistro:  "fedora",
+			inputRelease: "-3",
+			ok:           false,
+			errMsg:       "release must be a positive integer",
+		},
+		{
+			name:         "Fedora; foo; invalid; non-numeric",
+			inputDistro:  "fedora",
+			inputRelease: "foo",
+			ok:           false,
+			err:          strconv.ErrSyntax,
+		},
+		{
+			name:         "RHEL; 8.3; valid",
+			inputDistro:  "rhel",
+			inputRelease: "8.3",
+			output:       "8.3",
+			ok:           true,
+		},
+		{
+			name:         "RHEL; 8.42; valid",
+			inputDistro:  "rhel",
+			inputRelease: "8.42",
+			output:       "8.42",
+			ok:           true,
+		},
+		{
+			name:         "RHEL; 8; invalid; missing point release",
+			inputDistro:  "rhel",
+			inputRelease: "8",
+			ok:           false,
+			errMsg:       "release must have a '.'",
+		},
+		{
+			name:         "RHEL; 8.2foo; invalid; non-float",
+			inputDistro:  "rhel",
+			inputRelease: "8.2foo",
+			ok:           false,
+			err:          strconv.ErrSyntax,
+		},
+		{
+			name:         "RHEL; -2.1; invalid; less than 0",
+			inputDistro:  "rhel",
+			inputRelease: "-2.1",
+			ok:           false,
+			errMsg:       "release must be a positive number",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			release, err := ParseRelease(tc.inputDistro, tc.inputRelease)
+
+			if tc.ok {
+				assert.NoError(t, err)
+			} else {
+				assert.Error(t, err)
+
+				if tc.err != nil {
+					assert.ErrorIs(t, err, tc.err)
+				}
+
+				if tc.errMsg != "" {
+					assert.EqualError(t, err, tc.errMsg)
+				}
+			}
+
+			assert.Equal(t, tc.output, release)
+		})
+	}
+}