cmd: Add function to determine if a spinner can be started #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
6. Minor Change
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 3, 2021
The logic for determining if a spinner can be started is non-trivial and hard to replicate. containers#826
HarryMichal
force-pushed
the
cmd/add-spinner-check-func
branch
from
f73f062 to
aab6a2a
Compare
|
Build failed.
|
debarshiray
requested changes
Jul 5, 2021
There was a problem hiding this comment.
Is this still important with the current state of #787 ? At least it needs a rebase.
| "golang.org/x/crypto/ssh/terminal" | ||
| ) | ||
|
|
||
| func canStartSpinner() bool { |
There was a problem hiding this comment.
The spinner is only used in src/cmd/create.go, so this function should go in that file.
There was a problem hiding this comment.
I'd rather put it into src/cmd/utils.go because it isn't strictly related to the create command.
I'd merge it anyway. There's always the possibility of us adding a new spinner. |
The logic for determining if a spinner can be started is non-trivial and hard to replicate. containers#826
HarryMichal
force-pushed
the
cmd/add-spinner-check-func
branch
from
aab6a2a to
7d40b45
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for determining if a spinner can be started is non-trivial and
hard to replicate.