pkg/podman: Print stderr of execs to system stderr when asked for #823
+80
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
3. Enhancement
|
Build failed.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 3, 2021
Without this the logs of Podman (resp. stderr of Podman invocations) are shown only in chosen parts when the debug logs are requested. containers#823
HarryMichal
force-pushed
the
pkg/podman/proper-stderr-handling
branch
from
042a4c0 to
fcbc296
Compare
The logic for determining if a spinner can be started is non-trivial and hard to replicate. containers#826
With this the logs (resp. stderr) of all invocations of Podman are shown when the '--log-podman' option is set. This change affects the behaviour of spinner which is now hidden when the logging is turned on. containers#823
HarryMichal
force-pushed
the
pkg/podman/proper-stderr-handling
branch
from
fcbc296 to
28d97af
Compare
|
Build failed.
|
debarshiray
reviewed
Jul 4, 2021
There was a problem hiding this comment.
Nice trick with io.MultiWriter!
Sadly, this will won't unbreak the progress bar from podman pull when run as toolbox --verbose because the standard error stream won't be connected to a file descriptor that's a terminal device. We should mention that in the commit message.
|
Let's fold this into #787 |
debarshiray
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 4, 2021
This way the standard error stream of the spawned binaries can be inspected to get a better understanding of the failure, while still being shown to the user when run with the '--verbose' flag. Unfortunately, this breaks the progress bar in 'podman pull' because the standard error stream is no longer connected to a file descriptor that's a terminal device. containers#787 containers#823
debarshiray
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Jul 4, 2021
This way the standard error stream of the spawned binaries can be inspected to get a better understanding of the failure, while still being shown to the user when run with the '--verbose' flag. Unfortunately, this breaks the progress bar in 'podman pull' because the standard error stream is no longer connected to a file descriptor that's a terminal device. containers#689 containers#787 containers#823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this the logs (resp. stderr) of all invocations of Podman are shown
when the '--log-podman' option is set.
This change affects the behaviour of spinner which is now hidden when
the logging is turned on.
Depends on #826