Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a few more host locations inside the container under /run/host #264

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Expose a few more host locations inside the container under /run/host #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions toolbox
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,10 @@ create()
--volume /dev:/dev:rslave \
--volume /media:/media:rslave \
--volume /mnt:/mnt:rslave \
--volume /run:/run/host/run:rslave \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, but I see you chose /run/host instead of /host. Standardizing that path as much as we can is useful because other tools may come to rely on it. For example, things like Systemtap may want to look at /host/usr/lib/modules to find the host kernel.

I chose /host because oc debug node from OpenShift did.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I didn't know OpenShift uses /host. I did notice that you had went with /host, not /run/host.

I went with /run/host for no other reason than that we already had it for resolv.conf, and the original reason was just that it's the location that Flatpak uses.

I am happy to switch to /host or add some symbolic links or whatever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this, and think of /run/host versus /host in a separate PR or issue.

--volume /tmp:/run/host/tmp:rslave \
--volume /usr:/run/host/usr:rslave \
--volume /var:/run/host/var:rslave \
"$base_toolbox_image_full" \
toolbox --verbose init-container \
--home "$HOME" \
Expand Down