Expose a few more host locations inside the container under /run/host #264
Conversation
This is meant to alleviate some of the pain of not being able to modify the list of bind mounts once a toolbox container has been created. For some cases, especially where read-only access is enough, one can get by with setting up symbolic links inside the toolbox container. Based on an idea from Colin Walters. https://github.com/debarshiray/toolbox/pull/264
debarshiray
force-pushed
the
wip/rishi/more-host-locations-run-host
branch
from
e166e86 to
d63b0a9
Compare
| @@ -872,6 +872,10 @@ create() | |||
| --volume /dev:/dev:rslave \ | |||
| --volume /media:/media:rslave \ | |||
| --volume /mnt:/mnt:rslave \ | |||
| --volume /run:/run/host/run:rslave \ | |||
There was a problem hiding this comment.
Hm, but I see you chose /run/host instead of /host. Standardizing that path as much as we can is useful because other tools may come to rely on it. For example, things like Systemtap may want to look at /host/usr/lib/modules to find the host kernel.
I chose /host because oc debug node from OpenShift did.
There was a problem hiding this comment.
Interesting. I didn't know OpenShift uses /host. I did notice that you had went with /host, not /run/host.
I went with /run/host for no other reason than that we already had it for resolv.conf, and the original reason was just that it's the location that Flatpak uses.
I am happy to switch to /host or add some symbolic links or whatever.
There was a problem hiding this comment.
Let's merge this, and think of /run/host versus /host in a separate PR or issue.
You mean this line: We are also discussing it in containers/podman#4061 |
Should be fixed by https://github.com/debarshiray/toolbox/pull/276 We should roll a new release as soon as possible to address this regression. |
|
This is also affected by containers/crun#120 or https://github.com/debarshiray/toolbox/issues/282 on Fedora 31 Silverblue. |
This is meant to alleviate some of the pain of not being able to modify
the list of bind mounts once a toolbox container has been created. For
some cases, where read-only access is enough, one can get by with
setting up symbolic links inside the toolbox container.
Based on an idea from Colin Walters.