Add Dev, Nlink, and Ino to pkg/system/Stat struct #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podman needs to look at the Device, Inode and number of links of a file, but needs this to work on Windows and Darwin. We are using this information to determine if a file is a hard link whe tarring it up. Add new function FileInfoToStatT to transate a FileInfor into the StatT struct. Signed-off-by: Daniel J Walsh <[email protected]>
|
Lets wait for the podman PR to work before merging this. Since I have had a few changes to this found via podman. |
|
/hold |
|
Turns out @nalind does not like this, since the Windows version is returning bogus data, IE Nlink(), Dev(), Ino() always return 0, and this is wrong. So will implement everything in Podman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman needs to look at the Device, Inode and number of
links of a file, but needs this to work on Windows and
Darwin. We are using this information to determine if
a file is a hard link whe tarring it up.
Add new function FileInfoToStatT to transate a FileInfor into
the StatT struct.
Signed-off-by: Daniel J Walsh [email protected]