Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle hard links in remote builds #10421

Merged
merged 1 commit into from
May 24, 2021
Merged

Handle hard links in remote builds #10421

merged 1 commit into from
May 24, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 20, 2021

Fixes: #9893

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@edsantiago
Copy link
Member

Test LGTM, but I'm seeing a weird flake on my laptop (both root and rootless):

# podman-remote run --rm build_test stat -c %i /test/Dockerfile
35364677
time="2021-05-20T15:23:26-06:00" level=warning msg="Container 41fd5ed359ae351c1f021d0a7e57ca81576e3b193d8568d135febf79ee38daf0 does not exist: container 41fd5ed359ae351c1f021d0a7e57ca81576e3b193d8568d135febf79ee38daf0 does not exist in database: no such container"

Sometimes it happens on the first podman run, sometimes on the second. Once even on both.

@edsantiago
Copy link
Member

Flake filed as #10423

@rhatdan rhatdan changed the title Handle hard links in remote builds [WIP] Handle hard links in remote builds May 21, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2021
@rhatdan
Copy link
Member Author

rhatdan commented May 21, 2021

Requiers containers/storage#916 to be merged before we can merge this.

@rhatdan rhatdan force-pushed the build branch 3 times, most recently from 4e2ae7f to b5b74fc Compare May 22, 2021 09:23
@rhatdan rhatdan changed the title [WIP] Handle hard links in remote builds Handle hard links in remote builds May 24, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2021
giuseppe
giuseppe approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member

Flake looks like #7139 again

@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2311a02 into containers:master May 24, 2021
This was referenced May 24, 2021
Closed
Closed
Closed
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman-remote build: COPY does not preserve hardlinks
4 participants
@rhatdan @edsantiago @giuseppe @openshift-merge-robot