Use system defaults if storage.conf does not exist in XDG_CONFIG_HOME #1363
Conversation
|
@edsantiago PTAL |
|
LGTM, with a few tweaks for variable declarations. $ go mod edit --replace github.com/containers/storage=github.com/rhatdan/storage@config
$ make vendor
...
[fix setDefaults := colon-equals; fix err declaration below]
$ make
$ ./test/apiv2/test-apiv2 01
PASS! <--- would otherwise fail trying to read /home/esm/.something/storage.confI have not run a full test suite. |
rhatdan
force-pushed
the
config
branch
2 times, most recently
from
8d683a2 to
5845779
Compare
|
These lint errors are kind of not easy to read. Does anyone know why they're printing out on what looks like a single line? Any ideas on how to make them readable? |
|
Please open a vendor PR against Podman to be extra sure it's working :) |
|
We have a vendor PR, the proof-of-concept containers/* treadmill, but I can't wedge this in until it at least compiles. |
Isn't the vendor PR testing the main branch of c/storage? I saw this more as an extra security net but still expect us to try avoid merging breaking changes. |
Yes, but since it's still WIP, I'm playing with it, and I thought I could instrument it to pull in this PR just for grins. |
Follow up to containers#1357 Podman tests suggest that do not need to use XDG_CONFIG_HOME if storage.conf does not exists. In that case we fall back to /etc/containers/storage.conf and /usr/share/containers/storage.conf Signed-off-by: Daniel J Walsh <[email protected]>
|
Let's see: containers/podman#15910 |
|
Well, tests are failing, but I'm pretty sure that's containers/common#1162 (a different problem). The good news is that |
Follow up to #1357
Podman tests suggest that do not need to use XDG_CONFIG_HOME if storage.conf does not exists. In that case we fall back to /etc/containers/storage.conf and /usr/share/containers/storage.conf
Signed-off-by: Daniel J Walsh [email protected]