If XDG_CONFIG_HOME env is set we should use it and ignore defaults #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vrothberg PTAL |
nalind
reviewed
Sep 23, 2022
HPC Customers noticed that storage was attempting to read files in /usr and /etc, even though they set XDG_CONFIG_HOME, they expect to only read config files in this directory. Fixes: containers/podman#15680 (Actually partial fixes), need to look at other config files. Signed-off-by: Daniel J Walsh <[email protected]>
vrothberg
reviewed
Sep 26, 2022
|
Restarted the failed job. |
|
@rhatdan feel free to merge or rebase |
|
This breaks podman. |
rhatdan
added a commit
to rhatdan/storage
that referenced
this pull request
Sep 26, 2022
Follow up to containers#1357 Podman tests suggest that do not need to use XDG_CONFIG_HOME if storage.conf does not exists. In that case we fall back to /etc/containers/storage.conf and /usr/share/containers/storage.conf Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
added a commit
to rhatdan/storage
that referenced
this pull request
Sep 26, 2022
Follow up to containers#1357 Podman tests suggest that do not need to use XDG_CONFIG_HOME if storage.conf does not exists. In that case we fall back to /etc/containers/storage.conf and /usr/share/containers/storage.conf Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
added a commit
to rhatdan/storage
that referenced
this pull request
Sep 26, 2022
Follow up to containers#1357 Podman tests suggest that do not need to use XDG_CONFIG_HOME if storage.conf does not exists. In that case we fall back to /etc/containers/storage.conf and /usr/share/containers/storage.conf Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
added a commit
to rhatdan/storage
that referenced
this pull request
Sep 27, 2022
Follow up to containers#1357 Podman tests suggest that do not need to use XDG_CONFIG_HOME if storage.conf does not exists. In that case we fall back to /etc/containers/storage.conf and /usr/share/containers/storage.conf Signed-off-by: Daniel J Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HPC Customers noticed that storage was attempting to read files in /usr and /etc, even though they set XDG_CONFIG_HOME, they expect to only read config files in this directory.
Fixes: containers/podman#15680
(Actually partial fixes), need to look at other config files.
Signed-off-by: Daniel J Walsh [email protected]