Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TESTS NEEDED] Add ssh connection to root user #9920

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

ashley-cui
Copy link
Member

When initing a VM, create two add connections - one to user, one to
root.
podman machine remove removes both connections as well.

[NO TESTS NEEDED]

Signed-off-by: Ashley Cui [email protected]

When initing a VM, create two add connections - one to user, one to
root.
podman machine remove removes both connections as well.

[NO TESTS NEEDED]

Signed-off-by: Ashley Cui <[email protected]>
@TomSweeneyRedHat
Copy link
Member

Changes LGTM
but the remove --pull-never test is succeeding when it should fail. I'm not sure what's what there. @edsantiago is this a flake you're chasing?

@edsantiago
Copy link
Member

I've never seen this error; and it's a brand-new test in a PR that @rhatdan just merged (#9631). Is there any chance whatsoever that this isn't rebased against current master, or somehow had a merge conflict that was fixed inconsistently? (Sorry, can't probe deeply into it right now)

@ashley-cui
Copy link
Member Author

I rebased when I made the PR. I'll start the test again and if it fails again I'll rebase and repush

@edsantiago
Copy link
Member

And, it passed. This is frightening; it means we have a new flake. To be looked at next week.

@rhatdan
Copy link
Member

rhatdan commented Apr 2, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3ae4235 into containers:master Apr 2, 2021
@ashley-cui ashley-cui deleted the rooty branch June 29, 2021 21:13
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants