Fix podman build --pull-never #9631

rhatdan · 2021-03-05T11:15:58Z

Fixes: #9573

Signed-off-by: Daniel J Walsh [email protected]

openshift-ci-robot · 2021-03-05T11:16:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhatdan · 2021-03-05T11:16:41Z

This PR Requires containers/buildah#3062

TomSweeneyRedHat · 2021-03-06T00:43:22Z

go.mod

@@ -11,19 +11,19 @@ require (
 	github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd // indirect
 	github.com/containernetworking/cni v0.8.1
 	github.com/containernetworking/plugins v0.9.0
-	github.com/containers/buildah v1.19.7
-	github.com/containers/common v0.35.0
+	github.com/containers/buildah v1.19.2-0.20210305112159-898eea8fbefd


Shouldn't this be 1.20 something? I saw the commit in master, maybe I missed the 1.19 commit?

We have not created a 1.20 yet, so I just put in the current commit id. Since we have not updated the main branch beyond v1.19.2 this is what it show up as.
IE I set the version to
898eea8fbefd73993406610311cad8fcab045bad

And then make vendor-in-container changes it to the above. BTW I think it might be time to cut a new buildah release.

TomSweeneyRedHat · 2021-03-06T00:45:05Z

cmd/podman/images/build.go

@@ -307,7 +323,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil
 	}

 	if flags.PullNever {
-		pullPolicy = imagebuildah.PullIfMissing
+		pullPolicy = imagebuildah.PullNever


giuseppe · 2021-03-09T14:00:31Z

@cevich of those failing tests (e.g. podman fedora-33 root host), what are running inside of a privileged container?

cevich · 2021-03-09T16:07:29Z

what are running inside of a privileged container?

Should just be the ones that have container at the end of the name. i.e. int podman fedora-33 root container

edsantiago · 2021-03-24T20:42:40Z

I'm seeing Files changed: 131. Is that deliberate? I don't remember the earlier iteration.

rhatdan · 2021-03-24T20:57:33Z

@edsantiago This is all vendoring in a new version of Buildah. If we had a new release this PR would be much smaller.

edsantiago · 2021-03-24T21:11:11Z

OK. I'm confused about the vendor downgrade from buildah 1.19.8 to .2.something, but will leave that for others to worry about.

If you need to repush for any reason, what would you think of deleting these lines from the bud test?

podman/test/buildah-bud/buildah-tests.diff

Lines 106 to 113 in af91f27

    
           @@ -2023,6 +2028,7 @@ _EOF 
        
            } 
        
            @test "bud pull never" { 
        
           +  skip "FIXME: podman issue #9573" 
        
              target=pull 
        
              run_buildah 125 bud --signature-policy ${TESTSDIR}/policy.json -t ${target} --pull-never ${TESTSDIR}/bud/pull 
        
              expect_output --substring "pull policy is \"never\" but \""

rhatdan · 2021-03-24T21:48:15Z

Sure.

edsantiago · 2021-03-25T16:08:55Z

bud test failing:

 + git clone -q --branch v1.19.2-0.20210325094324-0c0ce48c77e8 https://github.com/containers/buildah test-buildah-v1.19.2-0.20210325094324-0c0ce48c77e8
 fatal: Remote branch v1.19.2-0.20210325094324-0c0ce48c77e8 not found in upstream origin

This is probably my fault: my bud test assumes that whatever is in go.mod can be checked out as a tag from the buildah repo. It looks like I need some way of detecting magic strings like v<xyz>-something-sha. What should be the exact git clone command for a string like that?

rhatdan · 2021-03-25T17:36:50Z

@cevich We should have a new major release soon, in buildah, so there should be no rush.

Currently pull policy is set incorrectly when users set --pull-never. Also pull-policy is not being translated correctly when using podman-remote. Fixes: containers#9573 Signed-off-by: Daniel J Walsh <[email protected]>

edsantiago · 2021-03-29T13:40:52Z

/lgtm

umohnani8 · 2021-03-29T13:41:43Z

LGTM

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021

rhatdan changed the title ~~Fix podman build --pull-never~~ [WIP] Fix podman build --pull-never Mar 5, 2021

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2021

rhatdan force-pushed the pull branch 2 times, most recently from e8b1860 to 8423eef Compare March 5, 2021 20:06

rhatdan changed the title ~~[WIP] Fix podman build --pull-never~~ Fix podman build --pull-never Mar 5, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2021

TomSweeneyRedHat reviewed Mar 6, 2021

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021

rhatdan force-pushed the pull branch from 8423eef to 638512c Compare March 7, 2021 11:27

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021

rhatdan force-pushed the pull branch 2 times, most recently from ac627ef to 7d694bd Compare March 8, 2021 17:04

rhatdan force-pushed the pull branch 6 times, most recently from 4e615b9 to 47fd974 Compare March 13, 2021 10:48

rhatdan force-pushed the pull branch 3 times, most recently from c0b9855 to 21d9a01 Compare March 20, 2021 11:47

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2021

rhatdan force-pushed the pull branch from 21d9a01 to a5f03d1 Compare March 20, 2021 12:27

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2021

rhatdan force-pushed the pull branch from a5f03d1 to b65eb8f Compare March 20, 2021 14:35

edsantiago mentioned this pull request Mar 21, 2021

run buildah bud tests using podman #9296

Merged

rhatdan force-pushed the pull branch 5 times, most recently from 039051e to d217898 Compare March 24, 2021 20:34

rhatdan force-pushed the pull branch from d217898 to 473eca1 Compare March 24, 2021 20:56

rhatdan force-pushed the pull branch 2 times, most recently from 1593df1 to b79d294 Compare March 25, 2021 13:18

rhatdan force-pushed the pull branch 4 times, most recently from 1f6948f to 521bebc Compare March 27, 2021 02:05

Fix podman build --pull-never

4d51995

Currently pull policy is set incorrectly when users set --pull-never. Also pull-policy is not being translated correctly when using podman-remote. Fixes: containers#9573 Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the pull branch from 521bebc to 4d51995 Compare March 27, 2021 09:33

openshift-ci-robot assigned edsantiago Mar 29, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021

openshift-merge-robot merged commit ac3499c into containers:master Mar 29, 2021

edsantiago mentioned this pull request Apr 1, 2021

[NO TESTS NEEDED] Add ssh connection to root user #9920

Merged

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix podman build --pull-never #9631

Fix podman build --pull-never #9631

rhatdan commented Mar 5, 2021

openshift-ci-robot commented Mar 5, 2021

rhatdan commented Mar 5, 2021

TomSweeneyRedHat Mar 6, 2021

rhatdan Mar 6, 2021

TomSweeneyRedHat Mar 6, 2021

giuseppe commented Mar 9, 2021 •

edited

Loading

cevich commented Mar 9, 2021

edsantiago commented Mar 24, 2021

rhatdan commented Mar 24, 2021

edsantiago commented Mar 24, 2021

rhatdan commented Mar 24, 2021

edsantiago commented Mar 25, 2021

rhatdan commented Mar 25, 2021

edsantiago commented Mar 29, 2021

umohnani8 commented Mar 29, 2021

Fix podman build --pull-never #9631

Fix podman build --pull-never #9631

Conversation

rhatdan commented Mar 5, 2021

openshift-ci-robot commented Mar 5, 2021

rhatdan commented Mar 5, 2021

TomSweeneyRedHat Mar 6, 2021

Choose a reason for hiding this comment

rhatdan Mar 6, 2021

Choose a reason for hiding this comment

TomSweeneyRedHat Mar 6, 2021

Choose a reason for hiding this comment

giuseppe commented Mar 9, 2021 • edited Loading

cevich commented Mar 9, 2021

edsantiago commented Mar 24, 2021

rhatdan commented Mar 24, 2021

edsantiago commented Mar 24, 2021

rhatdan commented Mar 24, 2021

edsantiago commented Mar 25, 2021

rhatdan commented Mar 25, 2021

edsantiago commented Mar 29, 2021

umohnani8 commented Mar 29, 2021

giuseppe commented Mar 9, 2021 •

edited

Loading