Fix images_test using inconsistent alpine:latest #9620
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
At some point, somehow the `quay.io/libpod/apline:latest` image changed. This is causing some integration tests to fail on this branch. Mainly these failures are caused by missed-expectations w/ the test image. Fix these test by using a specific, fixed, named image tag instead of 'latest' (which can change unpredictably). Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
v2.2_fix_alpine_latest
branch
from
57889b6 to
c318b30
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
We should start thinking of a deprecation of the v2.2 branch upstream in the next month or so. |
I'm all for it, just say the word. |
|
As I think about it more, I think we can do it now. We have to retain v2.2.1-rhel until RHEL 8.4 releases upstream, but I don't see us doing another 2.2.x release now that 3.0.x is out. |
|
@cevich Should we formalize this somewhere? We only support branch X until a newer branch, Y, is created and has a release done from it? |
I think it's a great idea. That would help me out, and set community expectations. Maybe we go one more step and also update the README.md to indicate the release is not supported? |
|
Closing in favor of #9664 |
github-actions
bot
added
the
locked - please file new issue/PR
At some point, somehow the
quay.io/libpod/apline:latestimage changed.This is causing integration tests to fail on this branch. Mainly
these failures are caused by missed-expectations w/ the test image. Fix
these test by using a specific, fixed, named image tag instead of
'latest' (which can change unpredictably).