Skip to content

Commit

Permalink
Fix images_test using inconsistent alpine:latest
Browse files Browse the repository at this point in the history
At some point, somehow the `quay.io/libpod/apline:latest` image changed.
This is causing some integration tests to fail on this branch.  Mainly
these failures are caused by missed-expectations w/ the test image. Fix
these test by using a specific, fixed, named image tag instead of
'latest' (which can change unpredictably).

Signed-off-by: Chris Evich <[email protected]>
  • Loading branch information
cevich committed Mar 4, 2021
1 parent c0ab432 commit c318b30
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/e2e/images_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,23 +188,23 @@ WORKDIR /test
})

It("podman images filter since image", func() {
dockerfile := `FROM quay.io/libpod/alpine:latest
dockerfile := `FROM quay.io/libpod/alpine:3.2
`
podmanTest.BuildImage(dockerfile, "foobar.com/before:latest", "false")
result := podmanTest.Podman([]string{"images", "-q", "-f", "since=quay.io/libpod/alpine:latest"})
result.WaitWithDefaultTimeout()
Expect(result).Should(Exit(0))
Expect(len(result.OutputToStringArray())).To(Equal(7))
Expect(len(result.OutputToStringArray())).To(Equal(8))
})

It("podman image list filter after image", func() {
dockerfile := `FROM quay.io/libpod/alpine:latest
dockerfile := `FROM quay.io/libpod/alpine:3.2
`
podmanTest.BuildImage(dockerfile, "foobar.com/before:latest", "false")
result := podmanTest.Podman([]string{"image", "list", "-q", "-f", "after=quay.io/libpod/alpine:latest"})
result.WaitWithDefaultTimeout()
Expect(result).Should(Exit(0))
Expect(result.OutputToStringArray()).Should(HaveLen(7), "list filter output: %q", result.OutputToString())
Expect(result.OutputToStringArray()).Should(HaveLen(8), "list filter output: %q", result.OutputToString())
})

It("podman images filter dangling", func() {
Expand Down

0 comments on commit c318b30

Please sign in to comment.