Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version package to track all versions #9601

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Use version package to track all versions #9601

merged 1 commit into from
Mar 4, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Mar 3, 2021

  • Server, bindings, and CLI all now pull version information from version
    package.
  • Current /libpod API version slaved to podman/libpod Version
  • Bindings validate against libpod API Minimal version
  • Remove pkg/bindings/bindings.go and updated tests

Fixes: #9207

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added the HTTP API Bug is in RESTful API label Mar 3, 2021
@jwhonce jwhonce requested a review from mheon March 3, 2021 18:17
@jwhonce jwhonce self-assigned this Mar 3, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2021
@jwhonce jwhonce marked this pull request as draft March 3, 2021 18:17
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2021
@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2021
@mheon
Copy link
Member

mheon commented Mar 3, 2021

LGTM!

@jwhonce jwhonce marked this pull request as ready for review March 3, 2021 18:21
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2021
@jwhonce jwhonce force-pushed the issues/9207 branch 2 times, most recently from 8084849 to d379cf2 Compare March 3, 2021 18:30
lsm5
lsm5 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes.

I can make the required changes in my autobuilder, so no worries on that.

/cc @ashcrow

@openshift-ci-robot
Copy link
Collaborator

@lsm5: GitHub didn't allow me to request PR reviews from the following users: ashcrow.

Note that only containers members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

LGTM assuming CI passes.

I can make the required changes in my autobuilder, so no worries on that.

/cc @ashcrow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce
Use version package to track all versions
f86d641 
* Server, bindings, and CLI all now pull version information from version
package.
* Current /libpod API version slaved to podman/libpod Version
* Bindings validate against libpod API Minimal version
* Remove pkg/bindings/bindings.go and updated tests

Fixes: containers#9207

Signed-off-by: Jhon Honce <[email protected]>
ashley-cui
ashley-cui reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 87a78c0 into containers:master Mar 4, 2021
@jwhonce jwhonce deleted the issues/9207 branch June 30, 2021 16:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

@lsm5 lsm5 lsm5 approved these changes

@mheon mheon Awaiting requested review from mheon

Assignees

@jwhonce jwhonce

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate API versions to libpod version package
6 participants
@jwhonce @mheon @openshift-ci-robot @lsm5 @ashley-cui @openshift-merge-robot