Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate API versions to libpod version package #9207

Closed
jwhonce opened this issue Feb 2, 2021 · 1 comment · Fixed by #9601
Closed

Consolidate API versions to libpod version package #9207

jwhonce opened this issue Feb 2, 2021 · 1 comment · Fixed by #9601
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@jwhonce
Copy link
Member

jwhonce commented Feb 2, 2021

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug (technical debt)

Description

Currently the API version is defined in the API package, the bindings, and the libpod version package

Describe the results you received:

Currently there are a possibility for the libpod and API version to drift without notice.

Describe the results you expected:

Consolidate API version maps for API and libpod into libpod version package. At least then you will see all versions in one file.

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

<= 3.0.0
@jwhonce jwhonce self-assigned this Feb 2, 2021
@openshift-ci-robot
Copy link
Collaborator

@jwhonce: The label(s) kind/(technical, kind/debt) cannot be applied, because the repository doesn't have them

In response to this:

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug (technical debt)

Description

Currently the API version is defined in the API package, the bindings, and the libpod version package

Describe the results you received:

Currently there are a possibility for the libpod and API version to drift without notice.

Describe the results you expected:

Consolidate API version maps for API and libpod into libpod version package. At least then you will see all versions in one file.

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

<= 3.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 2, 2021
@jwhonce jwhonce changed the title Consolidate API versions to lIbpod version package Consolidate API versions to libpod version package Feb 2, 2021
@edsantiago edsantiago added the parkinglot Not actively worked on, but should remain open label Feb 3, 2021
@jwhonce jwhonce removed the parkinglot Not actively worked on, but should remain open label Mar 3, 2021
jwhonce added a commit to jwhonce/podman that referenced this issue Mar 4, 2021
* Server, bindings, and CLI all now pull version information from version
package.
* Current /libpod API version slaved to podman/libpod Version
* Bindings validate against libpod API Minimal version
* Remove pkg/bindings/bindings.go and updated tests

Fixes: containers#9207

Signed-off-by: Jhon Honce <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants