[NO TESTS NEEDED] Allow podman play kube to read yaml file from stdin #9420
Conversation
openshift-ci-robot
added
the
approved
| @@ -4,12 +4,10 @@ | |||
| podman-play-kube - Create pods and containers based on Kubernetes YAML | |||
|
|
|||
| ## SYNOPSIS | |||
| **podman play kube** [*options*] *file*__.yml__ | |||
| **podman play kube** [*options*] **file**__.yml__|**-** | |||
There was a problem hiding this comment.
-**podman play kube** [*options*] **file**__.yml__|**-**
+**podman play kube** [*options*] *file.yml|-*
test/system/700-play.bats
Outdated
| load helpers | ||
|
|
||
| @test "podman play with stdin" { | ||
| run_podman play kube - <<< test.yaml |
There was a problem hiding this comment.
This can't possibly work. I have to assume that you know this, that this is simply a placeholder. (Reason: <<< means "the next argument is a string variable"; what you probably want is < $PODMAN_TMPDIR/test.yaml but you need to create that first.)
test/system/700-play.bats
Outdated
| } | ||
|
|
||
| @test "podman play" { | ||
| run_podman play kube test.yaml |
There was a problem hiding this comment.
Same, but different reason (test.yaml does not exist)
rhatdan
force-pushed
the
kube
branch
2 times, most recently
from
efe1880 to
fcf09c6
Compare
Fixes: containers#8996 Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
changed the title
|
This PR includes tests, but the test checker is screwed up, since it sees a rename but does not know tests were added. |
| Short: "Play a pod based on Kubernetes YAML.", | ||
| Long: kubeDescription, | ||
| RunE: kube, | ||
| Args: cobra.ExactArgs(1), | ||
| ValidArgsFunction: common.AutocompleteDefaultOneArg, | ||
| Example: `podman play kube nginx.yml | ||
| cat nginx.yml | podman play kube - |
| @@ -4,12 +4,10 @@ | |||
| podman-play-kube - Create pods and containers based on Kubernetes YAML | |||
|
|
|||
| ## SYNOPSIS | |||
| **podman play kube** [*options*] *file*__.yml__ | |||
| **podman play kube** [*options*] *file.yml|-* | |||
There was a problem hiding this comment.
IDK, but I think we want to keep the underscores?
There was a problem hiding this comment.
OOOPS, I'll trust @edsantiago's earlier comment.
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes: #8996
Signed-off-by: Daniel J Walsh [email protected]