-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell pipe support for "play kube" #9018
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ADIX7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
@containers/podman-maintainers
LGTM |
Your welcome! The documentation and tests are still needed. I guess they should be done before merging, right? |
Yes, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work with podman-remote
. You have to make a similar change in pkg/domain/infra/tunnel/play.go
Closes containers#8996 Similar to `cat pod.json | kubectl apply -f -` this commit adds support for input from shell pipe (ex `cat pod.json | podman play kube -`). To use input form pipe one may use '-' as file name, the same way as `kubectl apply -f -` Signed-off-by: Ádám Kovács <[email protected]>
19fc0a3
to
bc272ef
Compare
What should be the new usage syntax? |
I think we can just leave this as kube [options] KUBEFILE and then explain in the decription that "-" can be used as a kubefile name. |
I see #9420 went in, closing this one. |
Closes #8996
Similar to
cat pod.json | kubectl apply -f -
this commit adds supportfor input from shell pipe (ex
cat pod.json | podman play kube -
).To use input form pipe one may use '-' as file name, the same way as
kubectl apply -f -
Signed-off-by: Ádám Kovács [email protected]