Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell pipe support for "play kube" #9018

Closed
wants to merge 1 commit into from

Conversation

ADIX7
Copy link

@ADIX7 ADIX7 commented Jan 19, 2021

Closes #8996

Similar to cat pod.json | kubectl apply -f - this commit adds support
for input from shell pipe (ex cat pod.json | podman play kube -).
To use input form pipe one may use '-' as file name, the same way as
kubectl apply -f -

Signed-off-by: Ádám Kovács [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ADIX7
To complete the pull request process, please assign luap99 after the PR has been reviewed.
You can assign the PR to them by writing /assign @luap99 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@containers/podman-maintainers

@TomSweeneyRedHat
Copy link
Member

LGTM
Needs to be unset as a WIP before merging

@ADIX7
Copy link
Author

ADIX7 commented Jan 19, 2021

Your welcome! The documentation and tests are still needed. I guess they should be done before merging, right?

@Luap99
Copy link
Member

Luap99 commented Jan 19, 2021

The documentation and tests are still needed. I guess they should be done before merging, right?

Yes, please

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work with podman-remote. You have to make a similar change in pkg/domain/infra/tunnel/play.go

Closes containers#8996

Similar to `cat pod.json | kubectl apply -f -` this commit adds support
for input from shell pipe (ex `cat pod.json | podman play kube -`).
To use input form pipe one may use '-' as file name, the same way as
`kubectl apply -f -`

Signed-off-by: Ádám Kovács <[email protected]>
@ADIX7 ADIX7 force-pushed the play-kube-shell-pipe branch from 19fc0a3 to bc272ef Compare January 23, 2021 12:58
@ADIX7
Copy link
Author

ADIX7 commented Jan 23, 2021

What should be the new usage syntax? kube [options] KUBEFILE|- ? Or it should remain kube [options] KUBEFILE ?

@rhatdan
Copy link
Member

rhatdan commented Jan 25, 2021

I think we can just leave this as kube [options] KUBEFILE and then explain in the decription that "-" can be used as a kubefile name.

@ADIX7
Copy link
Author

ADIX7 commented Feb 22, 2021

I see #9420 went in, closing this one.

@ADIX7 ADIX7 closed this Feb 22, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"podman play kube" pipe input
6 participants