fix failing image e2e test #9370
Conversation
The timestamps of some images must have changed changing the number of expected filtered images. The test conditions seem fragile but for now it's more important to get CI back. Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@containers/podman-maintainers PTAL |
The logic in the e2e test for multiple network aliases is indicating the test should wait for the containerized nginx to be ready. As this may take some time, the test does an exponential backoff starting at 2050ms. Fix the logic by removing the `Expect(...)` call during the exponential backoff. Otherwise, the test errors immediately. Signed-off-by: Valentin Rothberg <[email protected]>
|
I was now struck by the e2e test for multiple network aliases. It should now be fixed with the second commit. |
| @@ -204,7 +204,7 @@ WORKDIR /test | |||
| result := podmanTest.Podman([]string{"image", "list", "-q", "-f", "after=quay.io/libpod/alpine:latest"}) | |||
| result.WaitWithDefaultTimeout() | |||
| Expect(result).Should(Exit(0)) | |||
| Expect(result.OutputToStringArray()).Should(HaveLen(7), "list filter output: %q", result.OutputToString()) | |||
There was a problem hiding this comment.
I am always leery about bumping expected results for a test that used to work. Are we sure that there's not a problem elsewhere?
There was a problem hiding this comment.
Yes, @baude rebuild images over the weekend since Quay was complaining.
|
The network alias test is still failing on ubuntu |
github-actions
bot
added
the
locked - please file new issue/PR
The timestamps of some images must have changed changing the number of
expected filtered images. The test conditions seem fragile but for now
it's more important to get CI back.
Signed-off-by: Valentin Rothberg [email protected]