correct startup error message

[vrothberg]

The error message when failing to create an image engine unconditionally
pointed to the Podman socket which is quite confusing when running
locally.

Move the error message to the point where the first ping to the service
fails.

[NO TESTS NEEDED]

Signed-off-by: Valentin Rothberg [email protected]

@containers/podman-maintainers

[vrothberg]

Note that the error message is still quite broad as it assumes that all errors would be caused by a remote-connection error but it's improving over the previous state.

[saschagrunert]

LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

I was wondering where that error message was comping from.
/lgtm
/hold

[vrothberg]

CI failures should be fixed with #9370

[Luap99]

I think it would be better to move the error wrap to pkg/bindings here

podman/pkg/bindings/connection.go

Line 126 in 30607d7

if err := pingNewConnection(ctx); err != nil {

Currently you can get something like this

$ bin/podman-remote --url abc  ps
Error: Cannot connect to the Podman socket, make sure there is a Podman REST API service running.: unable to create connection. "" is not a supported schema

If the url is invalid it is a client error and should not show something about the server.

[vrothberg]

@Luap99 sounds good! I'll update once CI is back green.

[mheon]

Very good catch! LGTM

[rhatdan]

/lgtm

[vrothberg]

/hold cancel