[v2.2.1-rhel] Cirrus: Fix running Validate task on branches #9326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref. fix for https://cirrus-ci.com/task/6628393229746176 |
cevich
changed the title
|
LGTM |
edsantiago
reviewed
Feb 22, 2021
Minor: Correct `$DEST_BRANCH` value to actual branch name. Otherwise this is similar change to PR containers#9063. Despite skipping the `Smoke` check, it was observed on a *new* branch, the `validate` task (specifically `git-validation`) will fail. This is because: * `$CIRRUS_LAST_GREEN_CHANGE` will be empty on a new branch. * `$CIRRUS_BASE_SHA` is always empty for runs triggered by branch-push * `$EPOCH_TEST_COMMIT` will be set to `YOU_FOUND_A_BUG`. Fix this by eliminating the `Smoke` task entirely, simplifying all the `make validate` operations into the `validate` cirrus task. Ensure this task does not run when a new branch or tag is pushed. Also, eliminate the `$CIRRUS_BUILD_ID` value as it's confusing and not actually used anywhere. It was formerly used for building VM images, but this has moved to another repo entirely. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
v2.2.1-rhel_replace_smoke
branch
from
623d68e to
d61babf
Compare
|
@edsantiago PTAL, this should be good-to-go now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite skipping the
Smokecheck, it was observed on a new branch,the
validatetask (specificallygit-validation) will fail. Thisis because:
$CIRRUS_LAST_GREEN_CHANGEwill be empty on a new branch.$CIRRUS_BASE_SHAis always empty for runs triggered by branch-push$EPOCH_TEST_COMMITwill be set toYOU_FOUND_A_BUG.Fix this by eliminating the
Smoketask entirely, simplifying allthe
make validateoperations into thevalidatecirrus task. Ensurethis task does not run when a new branch or tag is pushed.
Also, eliminate the
$CIRRUS_BUILD_IDvalue as it's confusing and notactually used anywhere. It was formerly used for building VM images,
but this has moved to another repo entirely.
Signed-off-by: Chris Evich [email protected]