[v2.2] Cirrus: Fix running Validate task on branches #9324
Conversation
Followup to 6917272 Despite skipping the `Smoke` check, it was observed on a *new* branch, the `validate` task (specifically `git-validation`) will fail. This is because: * `$CIRRUS_LAST_GREEN_CHANGE` will be empty on a new branch. * `$CIRRUS_BASE_SHA` is always empty for runs triggered by branch-push * `$EPOCH_TEST_COMMIT` will be set to `YOU_FOUND_A_BUG`. Fix this by eliminating the `Smoke` task entirely, simplifying all the `make validate` operations into the `validate` cirrus task. Ensure this task does not run when a new branch or tag is pushed. Also, eliminate the `$CIRRUS_BUILD_ID` value as it's confusing and not actually used anywhere. It was formerly used for building VM images, but this has moved to another repo entirely. Signed-off-by: Chris Evich <[email protected]>
|
Ref. failed branch-job: https://cirrus-ci.com/task/4775235637477376 |
cevich
changed the title
|
@edsantiago PTAL |
|
This is really difficult to review. I did so by eyeballing against #9063 and (manually) verifying that the changes look the same; I also ran /lgtm |
rhatdan
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes it was. |
github-actions
bot
added
the
locked - please file new issue/PR
Followup to 6917272
Despite skipping the
Smokecheck, it was observed on a new branch,the
validatetask (specificallygit-validation) will fail. Thisis because:
$CIRRUS_LAST_GREEN_CHANGEwill be empty on a new branch.$CIRRUS_BASE_SHAis always empty for runs triggered by branch-push$EPOCH_TEST_COMMITwill be set toYOU_FOUND_A_BUG.Fix this by eliminating the
Smoketask entirely, simplifying allthe
make validateoperations into thevalidatecirrus task. Ensurethis task does not run when a new branch or tag is pushed.
Also, eliminate the
$CIRRUS_BUILD_IDvalue as it's confusing and notactually used anywhere. It was formerly used for building VM images,
but this has moved to another repo entirely.
Signed-off-by: Chris Evich [email protected]