Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci: keep LC_ env variables to conmon #8935

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

giuseppe
Copy link
Member

it is necessary for conmon to deal with the correct locale, otherwise
it uses C as a fallback.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1893567
Requires: containers/conmon#215

Signed-off-by: Giuseppe Scrivano [email protected]

it is necessary for conmon to deal with the correct locale, otherwise
it uses C as a fallback.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1893567
Requires: containers/conmon#215

Signed-off-by: Giuseppe Scrivano <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any chance we can add a test?

@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2021

LGTM

@haircommander
Copy link
Collaborator

I was wondering why my fix didn't work. thanks for picking this up @giuseppe :)

@mheon
Copy link
Member

mheon commented Jan 11, 2021

I'm going to go ahead and merge - if a test gets added, we can do so in a further PR.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@giuseppe
Copy link
Member Author

I'm going to go ahead and merge - if a test gets added, we can do so in a further PR.

I think it would be better to have an updated conmon first so we can add an e2e test

@mheon
Copy link
Member

mheon commented Jan 11, 2021

/hold
Fair enough. Definitely need this in by Monday though.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2021

I have merged the fix in conmon, now we need @haircommander to cut a new release and then @cevich to create a new VM to testing.

@openshift-merge-robot openshift-merge-robot merged commit d2503ae into containers:master Jan 11, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2021

I have no problem with this being merged, so it will not effect anything, but it would be nice to make sure everything works correctly

@haircommander
Copy link
Collaborator

I have to deal with the backwards compat problem I mentioned last week, then I'll cut a release.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants