-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci: keep LC_ env variables to conmon #8935
oci: keep LC_ env variables to conmon #8935
Conversation
it is necessary for conmon to deal with the correct locale, otherwise it uses C as a fallback. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1893567 Requires: containers/conmon#215 Signed-off-by: Giuseppe Scrivano <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any chance we can add a test?
LGTM |
I was wondering why my fix didn't work. thanks for picking this up @giuseppe :) |
I'm going to go ahead and merge - if a test gets added, we can do so in a further PR. |
I think it would be better to have an updated conmon first so we can add an e2e test |
/hold |
I have merged the fix in conmon, now we need @haircommander to cut a new release and then @cevich to create a new VM to testing. |
I have no problem with this being merged, so it will not effect anything, but it would be nice to make sure everything works correctly |
I have to deal with the backwards compat problem I mentioned last week, then I'll cut a release. |
it is necessary for conmon to deal with the correct locale, otherwise
it uses C as a fallback.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1893567
Requires: containers/conmon#215
Signed-off-by: Giuseppe Scrivano [email protected]