set locale to inherit environment #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hunt <[email protected]>
|
some background: https://bugzilla.gnome.org/show_bug.cgi?id=737137 |
|
hm this did not do what I wanted... hold on this |
|
@haircommander Any movement on this? |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Jan 11, 2021
it is necessary for conmon to deal with the correct locale, otherwise it uses C as a fallback. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1893567 Requires: containers/conmon#215 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
the fix is correct but it is not enough, we also need: containers/podman#8935 |
giuseppe
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
LGTM
@haircommander feel free to merge as soon as you are fine with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix https://bugzilla.redhat.com/show_bug.cgi?id=1893567
Signed-off-by: Peter Hunt [email protected]