Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore compatible API for prune endpoints #8912

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Restore compatible API for prune endpoints #8912

merged 1 commit into from
Jan 8, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Jan 7, 2021

  • Restore correct API endpoint payloads including reclaimed space numbers
  • Include tests for API prune endpoints
  • Clean up function signatures with unused parameters
  • Update swagger for /networks/prune

Fixes #8891

Signed-off-by: Jhon Honce [email protected]

@jwhonce
Restore compatible API for prune endpoints
b059e10 
* Restore correct API endpoint payloads including reclaimed space numbers
* Include tests for API prune endpoints
* Clean up function signatures with unused parameters
* Update swagger for /networks/prune

Fixes containers#8891

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce added kind/bug Categorizes issue or PR as related to a bug. HTTP API Bug is in RESTful API labels Jan 7, 2021
@jwhonce jwhonce requested review from mheon and baude January 7, 2021 22:36
@jwhonce jwhonce self-assigned this Jan 7, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
vrothberg
vrothberg reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 8, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit a0b432d into containers:master Jan 8, 2021
@jwhonce jwhonce deleted the issues/8891 branch June 30, 2021 16:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@mheon mheon Awaiting requested review from mheon

@baude baude Awaiting requested review from baude

Assignees

@jwhonce jwhonce

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore API payloads for prune endpoints
5 participants
@jwhonce @openshift-ci-robot @rhatdan @vrothberg @openshift-merge-robot