Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore API payloads for prune endpoints #8891

Closed
jwhonce opened this issue Jan 5, 2021 · 0 comments · Fixed by #8912
Closed

Restore API payloads for prune endpoints #8891

jwhonce opened this issue Jan 5, 2021 · 0 comments · Fixed by #8912
Assignees
@jwhonce
Labels
HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@jwhonce
Copy link
Member

jwhonce commented Jan 5, 2021 •
edited
Loading

  • Rework pruning to report reclaimed space #8831 changed the prune API handlers to return new payloads
  • The original payloads need to be restored to meet compatibility requirements
  • The new code to determine reclaimed space should be retained
@jwhonce jwhonce added kind/bug Categorizes issue or PR as related to a bug. HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. labels Jan 5, 2021
@jwhonce jwhonce self-assigned this Jan 5, 2021
@jwhonce jwhonce mentioned this issue Jan 5, 2021
Merged
jwhonce added a commit to jwhonce/podman that referenced this issue Jan 7, 2021
@jwhonce
Restore compatible API for prune endpoints
b059e10 
* Restore correct API endpoint payloads including reclaimed space numbers
* Include tests for API prune endpoints
* Clean up function signatures with unused parameters
* Update swagger for /networks/prune

Fixes containers#8891

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce mentioned this issue Jan 7, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jwhonce jwhonce

Labels
HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore compatible API for prune endpoints jwhonce/podman
1 participant
@jwhonce