Remove the ability to use [name:tag] in podman load command #8877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
rhatdan
force-pushed
the
load
branch
2 times, most recently
from
b3c1bc0 to
637d630
Compare
|
Changes LGTM, But, you remove a few tests then the test run times out before it completes? I've restarted. |
|
@QiWang19 @vrothberg @mtrmac PTAL |
mtrmac
reviewed
Jan 8, 2021
| if t, ok := ref.(reference.Tagged); ok { | ||
| loadOpts.Tag = t.Tag() | ||
| } else { | ||
| loadOpts.Tag = "latest" |
There was a problem hiding this comment.
Shouldn’t the loadOpts.Tag field, and similarly all the way down (other than fixed APIs), be removed then, as well? Otherwise we won’t get rid of the ambiguity throughout the codebase.
rhatdan
force-pushed
the
load
branch
4 times, most recently
from
f0c32d6 to
911cca4
Compare
PR containers#8851 broke CI: it included "/var/run" strings that, per containers#8771, should have been just "/run". Signed-off-by: Ed Santiago <[email protected]>
Docker does not support this, and it is confusing what to do if the image has more then one tag. We are dropping support for this in podman 3.0 Fixes: containers#7387 Signed-off-by: Daniel J Walsh <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
May 31, 2023
We _usually_ have only one image in store, $IMAGE, but it's
perfectly fine to also have $SYSTEMD_IMAGE also. Fix a few
tests so they can handle that condition.
And, cleanup:
- remove a no-longer-useful test ("podman load NEWNAME",
functionality that was removed 2+ years ago in containers#8877)
- reorder some tests in the image-mount test, to make
them safer and easier to understand
- use no-such-image, not no-such-container, in image-mount test.
Computer don't care, but this human felt confused for a sec.
Signed-off-by: Ed Santiago <[email protected]>
Luap99
pushed a commit
to Luap99/libpod
that referenced
this pull request
Jun 1, 2023
We _usually_ have only one image in store, $IMAGE, but it's
perfectly fine to also have $SYSTEMD_IMAGE also. Fix a few
tests so they can handle that condition.
And, cleanup:
- remove a no-longer-useful test ("podman load NEWNAME",
functionality that was removed 2+ years ago in containers#8877)
- reorder some tests in the image-mount test, to make
them safer and easier to understand
- use no-such-image, not no-such-container, in image-mount test.
Computer don't care, but this human felt confused for a sec.
Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker does not support this, and it is confusing what to do if
the image has more then one tag. We are dropping support for this
in podman 3.0
Fixes: #7387
Signed-off-by: Daniel J Walsh [email protected]