Switch references of /var/run -> /run #8771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
edsantiago
reviewed
Dec 18, 2020
| @@ -75,7 +75,7 @@ EOF | |||
| is "$output" "/var/lib/containers/storage" "GraphRoot in expected place" | |||
| GRAPH_ROOT="$output" | |||
| run_podman info --format '{{.Store.RunRoot}}' | |||
| is "$output" "/var/run/containers/storage" "RunRoot in expected place" | |||
| is "$output" "/run/containers/storage" "RunRoot in expected place" | |||
There was a problem hiding this comment.
I think you want to stet this. From what I'm seeing, RunRoot goes a lot deeper and will require a lot more changes.
There was a problem hiding this comment.
I changed the match to match .*/run/containers/storage
|
LGTM |
rhatdan
force-pushed
the
run
branch
3 times, most recently
from
4996725 to
a9d5f2b
Compare
|
|
||
| Overrides the first `FROM` instruction within the Containerfile. If there are multiple | ||
| FROM instructions in a Containerfile, only the first is changed. | ||
|
|
There was a problem hiding this comment.
Looks like we need to get a Buildah release together soon and vendored....
|
Changes LGTM, but all kinds of test unhappiness. |
Systemd is now complaining or mentioning /var/run as a legacy directory. It has been many years where /var/run is a symlink to /run on all most distributions, make the change to the default. Partial fix for containers#8369 Signed-off-by: Daniel J Walsh <[email protected]>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 12, 2021
PR containers#8851 broke CI: it included "/var/run" strings that, per containers#8771, should have been just "/run". Signed-off-by: Ed Santiago <[email protected]>
Merged
rhatdan
pushed a commit
to rhatdan/podman
that referenced
this pull request
Jan 12, 2021
PR containers#8851 broke CI: it included "/var/run" strings that, per containers#8771, should have been just "/run". Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systemd is now complaining or mentioning /var/run as a legacy directory.
It has been many years where /var/run is a symlink to /run on all
most distributions, make the change to the default.
Partial fix for #8369
Signed-off-by: Daniel J Walsh [email protected]