Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIDFile= references a path below legacy directory #8369

Closed
mavit opened this issue Nov 17, 2020 · 5 comments
Closed

PIDFile= references a path below legacy directory #8369

mavit opened this issue Nov 17, 2020 · 5 comments
Assignees
@rhatdan
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@mavit
Copy link
Contributor

mavit commented Nov 17, 2020

Is this a BUG REPORT or FEATURE REQUEST?

/kind bug

Description

On starting a systemd service generated by podman generate systemd, log messages like the following are generated:

/etc/systemd/system/container-squeeze.service:17: PIDFile= references a path below legacy directory /var/run/, updating /var/run/containers/storage/overlay-containers/5e31ca2b09faaaa7719790b24796021874bf2790e6441c50f4f4e4dc3318046d/userdata/conmon.pid → /run/containers/storage/overlay-containers/5e31ca2b09faaaa7719790b24796021874bf2790e6441c50f4f4e4dc3318046d/userdata/conmon.pid; please update the unit file accordingly.

Steps to reproduce the issue:

  1. cd /etc/systemd/system && podman generate systemd --name --files foo
  2. systemctl enable --now container-foo.service
  3. systemctl status container-foo.service

Describe the results you received:
The generated file contained a line PIDFile=/var/run/...

Describe the results you expected:
The generated file contained a line PIDFile=/run/...

Additional information you deem important:
The issue appears to be cosmetic only for now.

Output of podman version:

Version:      2.1.1
API Version:  2.0.0
Go Version:   go1.14.9
Built:        Wed Sep 30 20:31:11 2020
OS/Arch:      linux/amd64

Package info (e.g. output of rpm -q podman or apt list podman):

podman-2.1.1-7.fc32.x86_64
systemd-245.8-2.fc32.x86_64

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?

No
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 17, 2020
@vrothberg
Copy link
Member

Thanks, @mavit!

@containers/podman-maintainers PTAL. Could we start doing a s/\/var\/run/\/run\/?

@rhatdan
Copy link
Member

rhatdan commented Nov 17, 2020

Yes, I think we should stop using /var/run and just use /run

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

rhatdan added a commit to rhatdan/common that referenced this issue Dec 18, 2020
@rhatdan
Switch references of /var/run -> /run
d37af09 
Systemd is now complaining or mentioning /var/run as a legacy directory.
It has been many years where /var/run is a symlink to /run on all
most distributions, make the change to the default.

Partial fix for containers/podman#8369

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan mentioned this issue Dec 18, 2020
Merged
rhatdan added a commit to rhatdan/storage that referenced this issue Dec 18, 2020
@rhatdan
Switch references of /var/run -> /run
fa5ff26 
Systemd is now complaining or mentioning /var/run as a legacy directory.
It has been many years where /var/run is a symlink to /run on all
most distributions, make the change to the default.

Partial fix for containers/podman#8369

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan mentioned this issue Dec 18, 2020
Merged
rhatdan added a commit to rhatdan/buildah that referenced this issue Dec 18, 2020
@rhatdan
Switch references of /var/run -> /run
18f3e87 
Systemd is now complaining or mentioning /var/run as a legacy directory.
It has been many years where /var/run is a symlink to /run on all
most distributions, make the change to the default.

Partial fix for containers/podman#8369

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan mentioned this issue Dec 18, 2020
Merged
@rhatdan rhatdan mentioned this issue Dec 18, 2020
Merged
@rhatdan rhatdan added kind/bug Categorizes issue or PR as related to a bug. and removed stale-issue kind/bug Categorizes issue or PR as related to a bug. labels Dec 24, 2020
@rhatdan rhatdan self-assigned this Dec 24, 2020
@rhatdan rhatdan added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Dec 24, 2020
rhatdan added a commit to rhatdan/podman that referenced this issue Jan 7, 2021
@rhatdan
Switch references of /var/run -> /run
d9ebbbf 
Systemd is now complaining or mentioning /var/run as a legacy directory.
It has been many years where /var/run is a symlink to /run on all
most distributions, make the change to the default.

Partial fix for containers#8369

Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@vrothberg
Copy link
Member

@rhatdan took care of it.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rhatdan rhatdan

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mavit @rhatdan @vrothberg @openshift-ci-robot