Use PasswordCallback instead of Password for ssh

[afbjorklund]

Currently asking for login password, even if not supported by
the ssh server. So wait with prompt until actually requested.

Closes #8498

[TomSweeneyRedHat]

LGTM
assuming happy tests
Nice work @afbjorklund , TYVM!

[afbjorklund]

Did manual tests, not sure if it had any regression suite (a bit of a hassle with ssh server and all)

#8498 (comment)

[ssbarnea]

Thanks! Clearly this approach is much better as most systems are configured with passwords disabled.

[afbjorklund]

For some reason, machine uses both a wellknown password and a ssh key for the VM...

Better leave the back door open, or something. I blame Docker (same as exporting /home)

Facing some usability issues when trying to add ssh identity keys and ssh host keys.

That is, you basically have to run both ssh-add and ssh-keyscan for the user. <sigh>

[Luap99]

LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, Luap99, ssbarnea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

This LGTM, but I'd like an ack from @jwhonce

[jwhonce]

/lgtm