Merge pull request #8596 from afbjorklund/password-callback

Use PasswordCallback instead of Password for ssh
containers · Dec 4, 2020 · 07af857 · 07af857
2 parents c55b831 + aaade40
commit 07af857
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/bindings/connection.go b/pkg/bindings/connection.go
@@ -207,11 +207,11 @@ func sshClient(_url *url.URL, secure bool, passPhrase string, identity string) (
 		authMethods = append(authMethods, ssh.Password(pw))
 	}
 	if len(authMethods) == 0 {
-		pass, err := terminal.ReadPassword("Login password:")
-		if err != nil {
-			return Connection{}, err
+		callback := func() (string, error) {
+			pass, err := terminal.ReadPassword("Login password:")
+			return string(pass), err
 		}
-		authMethods = append(authMethods, ssh.Password(string(pass)))
+		authMethods = append(authMethods, ssh.PasswordCallback(callback))
 	}
 
 	port := _url.Port()