Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Run validation tests in CI:DOCS mode #8297

Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Nov 10, 2020

No description provided.

@cevich cevich requested a review from edsantiago November 10, 2020 19:04
@edsantiago
Copy link
Member

This is going to fail CI, pending my (upcoming) PR

@edsantiago
Copy link
Member

Thank you for your quick action.

@cevich cevich force-pushed the restore_docs_testing branch from 83eafe7 to 818ffbc Compare November 10, 2020 19:21
@edsantiago
Copy link
Member

So, um, validate is not run on CI:DOCS.

@cevich cevich force-pushed the restore_docs_testing branch from 818ffbc to b43c9db Compare November 10, 2020 20:29
@cevich cevich changed the title Cirrus: Restore docs vs --help testing CI:DOCS: Restore docs vs --help testing Nov 10, 2020
cevich added a commit to cevich/automation_images that referenced this pull request Nov 10, 2020
@cevich cevich force-pushed the restore_docs_testing branch from b43c9db to 425ec65 Compare November 10, 2020 20:41
cevich added a commit to cevich/automation_images that referenced this pull request Nov 10, 2020
Comment on lines 54 to 57

# TODO: Remove the next line once FindBin included in VM image
dnf install -y perl-FindBin
make xref_helpmsgs_manpages # always require a complete build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these, I've solved the problem a different way in #8299. Once these lines are gone, I can rebase on your PR and try out CI-colon-docs. Thanks.

@cevich cevich force-pushed the restore_docs_testing branch from 425ec65 to 3e7100b Compare November 11, 2020 14:15
@cevich cevich changed the title CI:DOCS: Restore docs vs --help testing Cirrus: Run validation tests in CI:DOCS mode Nov 11, 2020
@edsantiago
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1952420 into containers:master Nov 11, 2020
@cevich cevich deleted the restore_docs_testing branch June 30, 2021 18:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants