Fedora perl package needed by podman docs checking #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edsantiago reminder: An approving github review will cause this to merge (assuming build/test is successful) |
edsantiago
reviewed
Nov 10, 2020
See containers/podman#8297 Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
add_perl_findbin
branch
from
aad44fa to
3beaf14
Compare
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Nov 11, 2020
Reason: include perl-FindBin RPM in f33 VM, needed for hack/xref-helpmsgs-manpages Ref: containers/automation_images#39 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Tested in containers/podman#8306 ; confirmed working (i.e. the Validate task ran xref-helpmsgs-manpages and passed)
|
Thanks @edsantiago for confirming, I appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See containers/podman#8297
Signed-off-by: Chris Evich [email protected]