Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore indent on JSON from podman inspect #8011

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Restore indent on JSON from podman inspect #8011

merged 1 commit into from
Oct 14, 2020

Conversation

mheon
Copy link
Member

@mheon mheon commented Oct 13, 2020

I don't know when this was disabled, but it's very hard to read without it.

@mheon
Restore indent on JSON from podman inspect
915591b 
I don't know when this was disabled, but it's very hard to read
without it.

Signed-off-by: Matthew Heon <[email protected]>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@mheon
Copy link
Member Author

mheon commented Oct 13, 2020

@containers/podman-maintainers PTAL

saschagrunert
saschagrunert approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QiWang19
Copy link
Contributor

LGTM

@mheon
Copy link
Member Author

mheon commented Oct 13, 2020 

[+0197s] Caching registry.access.redhat.com/ubi8-init at /tmp/ubi8-init.tar...Running: /var/tmp/go/src/github.com/containers/podman/bin/podman --root /tmp/crio --runroot /tmp/crio-run --runtime /usr/lib/cri-o-runc/sbin/runc --conmon /usr/libexec/podman/conmon --cni-config-dir /etc/cni/net.d --cgroup-manager systemd --tmpdir /tmp --events-backend file --storage-driver vfs pull registry.access.redhat.com/ubi8-init
[+0197s] Trying to pull registry.access.redhat.com/ubi8-init...
[+0197s]   can't talk to a V1 docker registry
[+0197s] Error: unable to pull registry.access.redhat.com/ubi8-init: Error initializing source docker://registry.access.redhat.com/ubi8-init:latest: can't talk to a V1 docker registry

Well that's new and exciting.

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 13, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
vrothberg
vrothberg reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit d30b4b7 into containers:master Oct 14, 2020
@edsantiago edsantiago mentioned this pull request Oct 14, 2020
Merged
edsantiago added a commit to edsantiago/libpod that referenced this pull request Oct 14, 2020
@edsantiago
System test additions
1646da8 
 - run --userns=keep-id: confirm that $HOME gets set (containers#8013)

 - inspect: confirm that JSON output is a sane number of
   lines (10 or more), not an unreadable one-liner (containers#8011
   and containers#8021). Do so with image, pod, network, volume
   because the code paths might be different.

 - cgroups: confirm that 'run' preserves cgroup manager (containers#7970)

 - sdnotify: reenable tests, and hope CI doesn't hang. This
   test was disabled on August 18 because CI jobs were hanging
   and timing out. My suspicion was that it was containers#7316, which
   in turn seems to have hinged on conmon containers#182. The latter
   was merged on Sep 16, so let's cross our fingers and see
   what happens.

Also: remove inaccurate warning from a networking test.

And, wow, fix is_cgroupsv2(), it has never actually worked.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this pull request Oct 14, 2020
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mheon @openshift-ci-robot @QiWang19 @TomSweeneyRedHat @rhatdan @vrothberg @saschagrunert @openshift-merge-robot