Run by shortname #182
Closed
Run by shortname #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Jan 3, 2018
libpod/runtime_img.go
Outdated
| @@ -370,8 +370,7 @@ func (k *Image) GetLocalImageName() (string, error) { | |||
| } | |||
| } | |||
| } | |||
| fqname, _ := k.GetFQName() | |||
| return fqname, nil | |||
| return "", nil | |||
|
The ways it is being used, an empty string means it didn't find the image locally so this is correct I believe. |
|
The function says it should return an error in that case - can you return ErrNoSuchImage and check for that as an indication it's not present locally? |
|
sorry, i misread the question ... yes it should return an error ... fixed now. |
|
LGTM |
rhatdan
reviewed
Jan 4, 2018
libpod/runtime_img.go
Outdated
| @@ -370,8 +370,7 @@ func (k *Image) GetLocalImageName() (string, error) { | |||
| } | |||
| } | |||
| } | |||
| fqname, _ := k.GetFQName() | |||
| return fqname, nil | |||
| return "", errors.Errorf("unable to find image locally") | |||
There was a problem hiding this comment.
Should we return
errors.Wrapf(storage.ErrImageUnknown, "unable to find image locally")
Also you should probably be consistent on the error message. Above you obtain, here you find. I think we should just stick to find.
While pulling by shortname (fedora-minimal) worked, running a container by the short name did not due to a logic error. Signed-off-by: baude <[email protected]>
|
📌 Commit bd8bdaf has been approved by |
|
⚡ Test exempted: merge already tested. |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Oct 14, 2020
- run --userns=keep-id: confirm that $HOME gets set (containers#8013) - inspect: confirm that JSON output is a sane number of lines (10 or more), not an unreadable one-liner (containers#8011 and containers#8021). Do so with image, pod, network, volume because the code paths might be different. - cgroups: confirm that 'run' preserves cgroup manager (containers#7970) - sdnotify: reenable tests, and hope CI doesn't hang. This test was disabled on August 18 because CI jobs were hanging and timing out. My suspicion was that it was containers#7316, which in turn seems to have hinged on conmon containers#182. The latter was merged on Sep 16, so let's cross our fingers and see what happens. Also: remove inaccurate warning from a networking test. And, wow, fix is_cgroupsv2(), it has never actually worked. Signed-off-by: Ed Santiago <[email protected]>
Merged
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pulling by shortname (fedora-minimal) worked, running a container
by the short name did not due to a logic error.
Signed-off-by: baude [email protected]