Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--format updates for images/diff.go #7969

Merged
merged 1 commit into from
Oct 8, 2020
Merged

--format updates for images/diff.go #7969

merged 1 commit into from
Oct 8, 2020
+5 −4

Conversation

ParkerVR
Copy link
Collaborator

@ParkerVR ParkerVR commented Oct 8, 2020

Connected to #7932
https://docs.google.com/document/d/1YwNkk7t9o-MUbIDcvSMFXkWlnKR-OlGjwD_L5axKx50

Now using podman parse for json in images/diff.go

Signed-off-by: Parker Van Roy [email protected]

@ParkerVR ParkerVR requested a review from jwhonce October 8, 2020 19:18
@ParkerVR ParkerVR self-assigned this Oct 8, 2020
@ParkerVR ParkerVR added the kind/bug Categorizes issue or PR as related to a bug. label Oct 8, 2020
@jwhonce
Copy link
Member

jwhonce commented Oct 8, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 8, 2020

/approve
/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ParkerVR, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@mheon
Copy link
Member

mheon commented Oct 8, 2020

LGTM, restarted one flake

@jwhonce
Copy link
Member

jwhonce commented Oct 8, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2587cba into containers:master Oct 8, 2020
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@rhatdan rhatdan

@ParkerVR ParkerVR

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ParkerVR @jwhonce @rhatdan @openshift-ci-robot @mheon @openshift-merge-robot